onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 300 forks source link

Fix unable to open a new file via CLI #2683

Closed ghost closed 5 years ago

ghost commented 5 years ago

See commit message for more information.

codecov[bot] commented 5 years ago

Codecov Report

Merging #2683 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   45.78%   45.77%   -0.01%     
==========================================
  Files         361      361              
  Lines       14634    14637       +3     
  Branches     1926     1927       +1     
==========================================
  Hits         6700     6700              
- Misses       7703     7706       +3     
  Partials      231      231
Impacted Files Coverage Δ
browser/src/App.ts 8.88% <0%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6128e77...f00b6ea. Read the comment docs.

bryphe commented 5 years ago

Thanks for the fix, @samvv ! I think this fixes an issue I have occasionally - I'll run oni someNewFile.md and it won't actually be created. Looks good to me! 👍