search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.36k stars 301 forks source link

Interactive tutorial broken in version 0.3.7 and 0.3.8 #2688

Open kifirkin opened 5 years ago

kifirkin commented 5 years ago

Oni Version: 0.3.8 Neovim Version (Linux only): 0.3.1 Operating System: Ubuntu 18.04 x64

Issue: Interactive tutorial doesn't work. Unable to complete first task int first tutorial.

Expected behavior: Interactive tutorial inline window goes into insert mode and input text goes to that window

Actual behavior: When I press i key to switch into insert mode inside interactive tutorial inline window, whole Tutorial tab goes into insert mode and input text goes somewhere in background

Steps to reproduce: Open first task in first tutorial, press i. Whole tab goes into insert mode instead of inline window

oni-bot[bot] commented 5 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

kifirkin commented 5 years ago

Version 0.3.9 has the same issue. seems like inline windows cant get focus

kifirkin commented 5 years ago

I've found place where this bug was introduced https://github.com/onivim/oni/commit/e612eb860224d9f36528501cfd7c3a221e635305#r31743213

UPD: seems that is not true.

Inline editor didn't get focus. But I can't find why :sob:

gtlaserbeast commented 5 years ago

I seem to be experiencing this same issue with the mac version. v0.3.9

Funeoz commented 5 years ago

Same here on Kubuntu 18.10 : v 0.3.9

kifirkin commented 5 years ago

I've tried to debug this thing a little bit: So I set autoFocus = true here https://github.com/onivim/oni/blob/c7b11e462cc97f56fce313106570e5bb1e02eee5/browser/src/Services/Learning/Tutorial/TutorialBufferLayer.tsx#L126 , but it seems that it helps once, if I open another tutorial, inline editor looses focus again.

Also after completing tutorial there are two problems:

  1. Keystroke counter doesn't work
  2. Completion layer doesn't handle input keys, so I can't restart with space or continue with enter key
danielo515 commented 5 years ago

I am experiencing this same problem in 0.3.9 for macos. It is a shame because I would love to complete all the tutorials

yzlnew commented 5 years ago

Having this issue on Windows. Oni 0.3.9 / NeoVim 0.3.1

frontendwizard commented 5 years ago

I'm experiencing this issue on 0.3.9 with neovim 0.3.4

goriunov commented 5 years ago

Same :(

slipsnip commented 5 years ago

Same issue on Oni 0.3.9 and Neovim 0.3.4

BigC4 commented 4 years ago

same pleas fix this soon neovim 0.4.3-1 oni 0.3.9-2