onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 300 forks source link

Git describe is inaccurate #2693

Open Towerism opened 5 years ago

Towerism commented 5 years ago

Issue: git describe is inaccurate, because the last few tags do not point to any commits on master.

Expected behavior: git describe should describe the master branch with the latest tag (as of writing it should look like this v0.3.9-X-XXXXXXX).

Actual behavior: Instead git describe looks like this: v0.3.7-beta2-35-geefa28326

Steps to reproduce: pull from the master branch and run git describe

I am maintaining the git version of onivim on the AUR (https://aur.archlinux.org/packages/onivim-git/). This makes it difficult to automate the versioning of the package.

oni-bot[bot] commented 5 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

justinmk commented 5 years ago

One way to deal with this is to "merge" the dangling tags back into master, but revert all of their changes in the merge-commit. So the tags will be reachable from master without actually needing to bring potentially irrelevant changes into master. Although I don't know if git describe would find tags that aren't on the master "mainline".