search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 300 forks source link

Light background #2707

Open goerz opened 5 years ago

goerz commented 5 years ago

Oni Version: 0.3.9 Neovim Version: v0.2.3-dev Operating System: macOS Mojave 10.14.2 (18C54)

Issue:

Cannot find a way to switch the GUI to light mode. I've tried to tweak some of the settings https://github.com/onivim/oni/issues/1708#issuecomment-399675613 but they just create a broken mess of unreadable text.

My color scheme is at https://github.com/goerz/vimrc/blob/17f67b6f85a0c5c5c7370b86426d4ff68894fba0/colors/goerz.vim and I'd like it to load the "light" version.

Expected behavior:

There should be a single configuration switch that provides a basic light UI (using the default light macOS app colors), so that my vim color scheme can pick up on &background=="light" to choose the correct colors.

Actual behavior:

It appears to be extremely difficult to get rid of the default dark UI scheme. I know dark UIs are fashionable these days, but personally I think they're an abomination. Presumably, I could configure all of the settings mentioned in https://github.com/onivim/oni/blob/master/browser/src/Services/Themes/ThemeManager.ts, but I wasn't really planning to spend hours basically recreating my color scheme that way.

oni-bot[bot] commented 5 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

goerz commented 5 years ago

Screenshot comparison between Oni and terminal neovim (which is pretty much what I'd like to see in Oni):

screenshot_2019-01-05_19 05 37_8iz3o3 screenshot_2019-01-05_19 05 43_dmkrcb