Fix NeoVIM >= 0.3.2 - Githubissues

onivim / oni

Oni: Modern Modal Editing - powered by Neovim

https://www.onivim.io

MIT License

11.36k stars 301 forks source link

Fix NeoVIM >= 0.3.2 #2712

Open losinggeneration opened 5 years ago

losinggeneration commented 5 years ago

NeoVIM 0.3.2 changed the command line options so that --embed no longer implies --headless. This adds it back to be explicitly set.
See neovim/neovim@4da5cb38d396d76d8072815d150725f7c9a85078

https://github.com/onivim/oni/issues/2704#issuecomment-453270503 @CrossR mentions working on what's probably a more proper update based on the new behavior for neovim>=0.3.2. This PR just restores the previous behavior.

I believe this closes #2706 and also closes #2704

justinmk commented 5 years ago

This will stop the bleeding, but it also completely defeats the purpose of the improved --embed behavior, so I hope https://github.com/onivim/oni/pull/2613 is resolved.

losinggeneration commented 5 years ago

@justinmk Exactly, I forgot to link to that. Basically this just gets it back to working until #2613 is finished up.