search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.36k stars 301 forks source link

Oni does not respect editor.quickOpen.execCommand #2754

Open sethfowler opened 4 years ago

sethfowler commented 4 years ago

Oni Version: 0.3.9 Neovim Version (Linux only): Operating System: macOS

Issue: Despite the documentation, setting editor.quickOpen.execCommand has no effect - ripgrep is always used.

Expected behavior: It should be possible to use editor.quickOpen.execCommand to substitute another fuzzy finder for ripgrep.

Actual behavior: Ripgrep is used no matter what.

Steps to reproduce: Set editor.quickOpen.execCommand to something other than rg. Observe via Activity Monitor that rg is running, and not the command you specified.

This is a bummer because rg is unusably slow on larger repositories.

As far as I can tell, the current version of the code doesn't even attempt to respect editor.quickOpen.execCommand (though I may be missing something). Maybe support was accidentally removed during a refactor?

oni-bot[bot] commented 4 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.