onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

Oni frequent crash on Windows 7 #490

Closed saibing closed 6 years ago

saibing commented 7 years ago

Oni frequent crash on Windows 7, such as the following scenario will crash:

Oni version:

* fa8a529 (HEAD -> master, origin/master, origin/HEAD) Fix #407, use editor.quickOpen.execCommand to filter files in qui
ckOpen (#489)
bryphe commented 7 years ago

Thanks for reporting this, @saibing !

I've seen random crashes on Windows 10 as well. It looks like that the Neovim process is actually closing, and then Oni quits in response to that.

It might be related to a couple of crashes reported in Neovim:

There's also the possibility that some of the work Oni is doing (like incremental buffer updates) is exacerbating an existing crash in Neovim. I need to see if there is more info I can get from the actual crash in Neovim.

A couple questions though that might help narrow this down:

saibing commented 7 years ago

@extr0py

my oni config's content as follow:

module.exports = {
  //add custom config here, such as
  //"oni.useDefaultConfig": true,
  "oni.loadInitVim": false,
  "editor.fontSize": "15px",
  "editor.fontFamily": "Source Code Pro",
  "editor.quickOpen.execCommand": "fzf -f ${search}"
}
badosu commented 7 years ago

I think this must be windows related as I have used Oni for a month now and did not have a single crash.

bryphe commented 6 years ago

The good news here is I've been testing out a new nightly build and it seems much more stable on Windows (no crashes). I'll plan on upgrading Oni to use 0.2.1 as soon as it is out.

bryphe commented 6 years ago

Upgraded to neovim 0.2.1 addresses this - #875 (at least, haven't seen any crashes!).

Feel free to open a new issue if you are still seeing this, though. I'm going to cut a new release shortly with neovim 0.2.1 binaries.