search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 301 forks source link

ctrl-c in cmd kills oni - closing cmd also closes oni #970

Open fpn opened 6 years ago

fpn commented 6 years ago

Oni seems somehow to be attached to its parent process:

ctrl-c in cmd kills oni

Open cmd on windows 10

Start oni:

oni

do dir or some other command.

do ctrl-c in cmd and oni will exit

Expected: oni is not affected by cmd

closing cmd also closes oni

Open cmd on windows 10 start oni:

oni

close cmd window -> oni will exit

Expected: oni is not affected by cmd

badosu commented 6 years ago

@fpn Just tested this on linux and it seems to be working, do you still experience this problem?

badosu commented 6 years ago

Tested in Linux and it seems Oni's detached from the terminal, if someone can reproduce this bug on windows or another platform let's reopen this.

fpn commented 6 years ago

@badosu - yes this bug is still present on windows in 0.3.6

CrossR commented 6 years ago

https://github.com/onivim/oni/pull/2372 should fix this hopefully, but worth leaving this open just to check when we release.