search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 282 forks source link

Windows - Installer: Investigate not requiring admin privileges to install #1407

Open bryphe opened 4 years ago

bryphe commented 4 years ago

On Windows, we use InnoSetup to build our installer - and the default setting is to require administrative privileges.

We install to %ProgramFiles%, as well as give the user the option of adding registry keys to use Onivim 2 to open common file types - so we require administrative permissions for those.

We could investigate an option to install the application w/o administrative privileges.

It looks like VSCode creates two distributions of their Windows installer - system installer, which requires administrative privileges, and a user installer, which does not.

This is implemented in their innosetup script like: https://github.com/microsoft/vscode/blob/1420967188b1a2ef98326cbb30b0fa5fc219b1c4/build/win32/code.iss#L40

We could consider a similar strategy (releasing User + System installation, or just switching to a default of a non-administrator setup).

bryphe commented 4 years ago

As a workaround in the meantime - the 'zip' distribution should be usable without administrative access.