HTML syntax highlighting is not displayed

onivim / oni2

Native, lightweight modal code editor

https://v2.onivim.io

MIT License

7.83k stars 282 forks source link

HTML syntax highlighting is not displayed #1879

Closed thecodejedi closed 4 years ago

thecodejedi commented 4 years ago

I'm opening a partial .html file and there is no syntax highlighting. Full html files with tag do work, correctly.

Highlighting for .ts files work, also highlighting of CSS or JS in an html work correctly.

Here is a screenshot of my problem: Screenshot from 2020-06-06 11-45-27

here is a log of just opening the file with -f --debug

this is the source of the file I tried to open.

I'm on Fedora 32 with GDM on Wayland. (5.6.15-300.fc32.x86_64)

bryphe commented 4 years ago

This looks like a similar issue to https://github.com/onivim/oni2/issues/1899 - a problem with our default OneDark-Pro theme. I'm able to reproduce with that theme:

But other themes, like Monokai, seem to work correctly:

yunti commented 4 years ago

Just came across this issue today, seems I get it with full html files.
I'm on the onedark-pro theme as that was the earlier default theme. What's the default/most tested theme now, so I can switch to that?

yunti commented 4 years ago

Note syntax highlighting support varies per theme quite a bit eg for jsx in js files. (possibly related)

Dark + theme.

one dark pro

bryphe commented 4 years ago

This looks better now with #2301 👍