onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 282 forks source link

Injection Grammar Support: Styled-components extension not working #2118

Open pmizio opened 4 years ago

pmizio commented 4 years ago

Like in title extension not crash oni but syntax higlighting in template literals not work nor there not any code completion for css properties. Tested on lastest oni extension installed via --install-extension flag. I think it is very popular staff in react world and support for it should matter ;) Extension link: https://open-vsx.org/extension/jpoissonnier/vscode-styled-components

CrossR commented 4 years ago

I believe right now we don't support embedded syntaxes, which would cause this issue. I could have missed some updates/be confused with something else though. We would like to support them!

bryphe commented 4 years ago

We're missing support for 'Injection Grammars': https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#injection-grammars - grammars that extend existing textmate grammars

pmizio commented 4 years ago

Just for information, how far it is on wait queue? Unfortunately for me as react dev it is daily blocker.

bryphe commented 4 years ago

Hi @Miziak - unfortunately I didn't plan it for it for the Oct / 0.6.0 milestone (and it's already pretty packed!). I marked as a daily-editor-blocker and will look at it for the 0.7.0 milestone

yunti commented 4 years ago

Yup this is a daily blocker for me too. (the injection grammar support - not the specific bit related to styled components).