onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.84k stars 282 forks source link

Syntax Highlighting: Terraform - Not getting full highlights #2220

Open bryphe opened 4 years ago

bryphe commented 4 years ago

Plugin: https://github.com/hashicorp/vscode-terraform (downloaded from: https://github.com/hashicorp/vscode-terraform/releases/download/v2.1.1/terraform-2.1.1.vsix)

Example file: https://github.com/terraform-providers/terraform-provider-aws/blob/master/examples/alexa/main.tf

Some syntax highlights are not present in Onivim for this syntax / theme pair - VSCode: image

Onivim: image

Need to investigate and see if it's a problem with our handling of the textmate grammar - or if it is a problem with theme matching

LeonT-A commented 4 years ago

Just ran into this myself and see that it's already mentioned. Thanks for your effort!

Extension: Ayu Dark Lighter

VSCode

Oni

Same thing with every Ayu variant I've tried, excpet for Ayu Dark Meta, which displays at it should.

fabriziosestito commented 4 years ago

+1 I ran into this problem with certain themes and elixir-ls

E.g. Nord theme arcticicestudio.nord-visual-studio-code

VSCode: image

Oni: image

Notice how the module name are in the standard foreground color. Note: I am using a bracket pair colorizer in VSCode but not in Oni