search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 282 forks source link

Symbolic Link folders are appearing as empty files #2657

Closed robotichead closed 3 years ago

robotichead commented 3 years ago

Method

  1. Create your Django Project

  2. Use git to clone your code NOT into the Django project folder

  3. Use ln -s to symbolic link the Django Application folder from the git source into the Django Project folder

  4. Open up Onivim 2

Expected Results

The symbolic linked folders to act like folders

Actual Results

Acts like a blank file

Image of the folders on Finder (mac) - please note the symbolic link for the NearBeach folder image

Image of Onivim - please note the lack of folder support for the NearBeach folder image

Image of the opened symbolic link folder image

Note

I have only tried this on Mac. I am more than happy to also try this out on Linux.

CrossR commented 3 years ago

That fits with what I see in the code:

https://github.com/onivim/oni2/blob/28e55c7ab77e9d629ad7698f73c1a90c88444c1a/src/Components/FileExplorer/Component_FileExplorer.re#L23-L32

I.e. when kind is a Link its treated as a file, not as a dir (well....there should be a lookup for the sort of link I guess).

That should probably be updated to check what the link actually resolves to.