onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.84k stars 282 forks source link

Support for icon themes #2858

Open petertriho opened 3 years ago

petertriho commented 3 years ago

I'm not sure if icon themes are currently supported. I tried material icon theme (pkief.material-icon-theme) and it does not appear to change my icons in explorer. It appears that folders aren't showing an icon as well (although I have seen other people have posted screenshots with folders icons working). For me, the folder icons don't appear with the default vs-seti either

OS: MacOS Catalina 10.15.6 Build: Tried Version 0.5.9-nightly (0.5.1740) and 0.5.1 stable Configuration:

{
    "editor.fontFamily": "FiraCode Nerd Font",
    "editor.fontSize": 12,
    "files.exclude": ["_esy", "node_modules", ".git"],
    "workbench.colorTheme": "GitHub Dark",
    "workbench.iconTheme": "material-icon-theme",
    "ui.zoom": 1.2,
    "vim.useSystemClipboard": true,
    "vim.leader": "<space>"
}
Screen Shot 2020-12-18 at 4 39 51 pm
NarongOk commented 3 years ago

Me too

alexventuraio commented 3 years ago

Same here!

trivial-zero commented 3 years ago

same here

rhyses-pieces commented 3 years ago

just tried out onivim for a little bit and noticed this issue as well. i'm wondering if it's possible to just replicate the way they're pulling in theme extensions and use that for icon themes? if that makes sense