freeze problem using vim-style substitution commands

onivim / oni2

Native, lightweight modal code editor

https://v2.onivim.io

MIT License

7.84k stars 282 forks source link

freeze problem using vim-style substitution commands #3155

Open jerabaul29 opened 3 years ago

jerabaul29 commented 3 years ago

On Ubuntu 20.04, Onivim 2 (0.5.9-nightly).

Attempting to perform a vim-style substitution command freezes my whole onivim2.

For example:

:%s/blip/blop/gc

freezes my whole editor. The only option I have then is to hard-kill the editor.

jerabaul29 commented 3 years ago

(that is a real problem in daily life as I rely quite a bit on these commands; does not seem that Crtl-H neither Ctrl-h bring up a substitution tool either).

bryphe commented 3 years ago

Related to #1159 , https://github.com/onivim/oni2/issues/2965 , and #3145

I just pushed up a fix recently to address the crash (because it's horrible to hit a crash in this path) - Onivim shows a warning now with #3145:

2021-02-22 13 10 53

We still need to build the find-replace experience, though (ie, fully support the c flag)

jerabaul29 commented 3 years ago

Thanks :) . Yes, it is tough to have such a "muscle memory" thing crashing the editor, great with the warning :) . Looking forward to the full fix :) .