How to perform some code refactoring with onivim2?

[jerabaul29]

How should code refactoring be performed in Onivim2? Things like changing variable names across files, changing snippets, etc? Are some tools available / implemented in onivim2 for that?

[bryphe]

Good question - this is actually something I'm planning to look at for the next milestone's work. At least, integrating code refactorings that are provided by VSCode extensions.

From the UI perspective, I plan to:

• Show the lightbulb icon, similar to VSCode, when there are refactorings (quick fixes / code actions) available in the context of the current cursor position.
• Add a quick and easy normal mode command - my current thought is ga (goto code-action), and gA (apply all quick fixes in the current file). This does conflict with an existing Vim key (ga , which prints the ascii value of the character under the cursor), but I believe from a utility perspective this is reasonable.
• When ga is pressed, or the 'lightbulb' is clicked, a context menu will show the available refactorings - navigable by Control+n / Control+p like the other context menus.

From the technical side, we'll integrate with the codeAction and codeAction/resolve APIs - which are these extension host APIs: https://github.com/onivim/vscode-exthost/blob/0d6b39803352369daaa97a444ff76352d8452be2/src/vs/workbench/api/common/extHost.protocol.ts#L1495

We'll also need to implement these APIs:

• workspace.$tryApplyWorkspaceEdits: https://github.com/onivim/vscode-exthost/blob/0d6b39803352369daaa97a444ff76352d8452be2/src/vs/workbench/api/common/extHost.protocol.ts#L278
• editor.$tryApplyEdit: https://github.com/onivim/vscode-exthost/blob/0d6b39803352369daaa97a444ff76352d8452be2/src/vs/workbench/api/common/extHost.protocol.ts#L292

Related to #3231 #3017

[brainpicture]

Literally waiting only for this feature. Looks like this is the last blocker I have.

[jesstelford]

$tryApplyEdits has been implemented in https://github.com/onivim/oni2/pull/3571