onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 282 forks source link

Color scheme inacuracies #3282

Open Apostolique opened 3 years ago

Apostolique commented 3 years ago

I have made my own theme: https://github.com/Apostolique/AposTheme.

It is available on open vsx: https://open-vsx.org/extension/vyne/apostheme.

In: https://github.com/Apostolique/Apos.History/blob/master/Source/History.cs

Oni2: Oni2 vscode: vscode

Differences: The /// comments should be gray. The constructor parameter HistoryHandler should be orange.

I'll make separate posts for other differences that I find.

Apostolique commented 3 years ago

In: https://github.com/Apostolique/Apos.History/blob/master/README.md

Oni2: Oni2

vscode: vscode

The markdown headers should be blue. The brackets should be green. The parentheses should be yellow.

bryphe commented 3 years ago

Thanks @Apostolique for the details and screenshots! Will be a great test case for the next round of syntax highlighting fixes 👍

Apostolique commented 3 years ago

In: https://github.com/Apostolique/apos-docs/blob/master/README.md

Oni2: Oni2

vscode: vscode

The markdown inline code (backticks) should be orange.

Apostolique commented 3 years ago

In: https://github.com/Apostolique/apos-docs/blob/master/index.js

Oni2: Oni2

vscode: image

The #! should also be gray.

Apostolique commented 3 years ago

In: https://github.com/Apostolique/apos-docs/blob/master/src/styles/tailwind.config.js#L73

Oni2: Oni2

vscode: vscode

Some of the theme functions aren't green. Also the single quotes around the figure figcaption key shouldn't be yellow.