Make command issues

[jrwrigh]

Two primary issues in trying to use make with onivim2:

1. Using built-in :make There's not evidence to the user that this does anything. No error messages, nor confirmation that it is/isn't running, or that it has completely succesfully.

2. Using make from the terminal Results in an Makefile error... coming from onivim 2. Running with make -n (verbose) shows that where it should be running make, it's not running onivim2:

In normal terminal:

[...]
make -s -f CMakeFiles/Makefile2 all
[continues sucessfullly]

In onivim2 terminal:

[...]
onivim2 -s -f CMakeFiles/Makefile2 all
[continues successfully]

I have a feeling that the first issue is being caused by the second, but with the side-effect that it isn't relaying the fact that make returns an error.

Version:

onivim2: Onivim 2 (0.5.9-nightly) OS: (Linux) Manjaro

[bryphe]

Thanks @jrwrigh for logging the issue!

I suspect these are related to some of the quickfix errors in #3332 . That's an interesting observations about the make command being superceded.

I'd be curious what the delta is from the output of the env command in the Onivim2 terminal vs normal terminal - might be a clue there why the command is being overridden.

[jrwrigh]

Below is a diff of the output of env from the onivim2 terminal (onivim2ENV) and my normal terminal session (termENV).

ENV diff

```diff ❯ diff <(sort onivim2ENV) <(sort termENV) 1,3d0 < APPDIR=/tmp/.mount_onivimPR8w7L < APPIMAGE=/home/jrwrigh/.local/src/onivim2/Onivim2-x86_64-master.AppImage < APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL=true 16d12 < GIT_ASKPASS=/tmp/.mount_onivimPR8w7L/usr/bin/extensions/git/out/askpass.sh 33d28 < LD_LIBRARY_PATH= 41,44c36 < OLDPWD=/home/jrwrigh/gitRepos/CMGLab_STG_Presentation_2021 < ONI2_ORIG_PATH=/home/jrwrigh/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl < ONIVIM_TERMINAL=0.5.9-nightly < OWD=/home/jrwrigh --- > OLDPWD=/home/jrwrigh 50c42 < SHLVL=2 --- > SHLVL=1 52c44 < STARSHIP_SESSION_KEY=1115747261962128 --- > STARSHIP_SESSION_KEY=2591744916489105 55,56d46 < TERM_PROGRAM_VERSION=1.53.0 < TERM_PROGRAM=vscode 63,64d52 < VIMRUNTIME=/usr/local/share/vim < VIM=/usr/local/share/vim 66,68c54,55 < VSCODE_GIT_ASKPASS_MAIN=/tmp/.mount_onivimPR8w7L/usr/bin/extensions/git/out/askpass-main.js < VSCODE_GIT_ASKPASS_NODE=/tmp/.mount_onivimPR8w7L/usr/bin/node < VSCODE_GIT_IPC_HANDLE=/run/user/1000/vscode-git-b1f1465e47.sock --- > VTE_VERSION=6203 > WINDOWID=93941040 ```

$PATH did not actually change value, which I find interesting (as that's exactly where I'd expect the issue to be).