Open bryphe opened 3 years ago
I was just about to post an issue about this in relation to differences between the same theme in VSCode & Oni2.
But I noticed that switching off semantic highlighting in VSCode will render things (virtually?) identically to Oni2, so I guess the discrepancies are semantic highlighting... 😄
The extension host provides some APIs for semantic highlighting:
https://github.com/onivim/vscode-exthost/blob/0d6b39803352369daaa97a444ff76352d8452be2/src/vs/workbench/api/common/extHost.protocol.ts#L400
and
https://github.com/onivim/vscode-exthost/blob/0d6b39803352369daaa97a444ff76352d8452be2/src/vs/workbench/api/common/extHost.protocol.ts#L1508
We need to wire these APIs up, and integrate them into our language feature / syntax highlighting pipeline, to support languages that use these rich semantic highlights.
Some extensions to test with semantic token support: