search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.84k stars 282 forks source link

Extension "Spell Right" fail to activate #3463

Open Samonitari opened 3 years ago

Samonitari commented 3 years ago

Something is missing for a wrorking Spell Right extension (I prefer this spell checker over the Code Spell Checker, mainly because the former can use the system dictionaries, but other reasons as well...)

During startup, Oni2 produces this notification: Error activating extension ban.spellright: Activating extension 'ban.spellright' failed: Cannot read property 'Spellchecker' of null.

Spellright commands are added to the palette, but neither of them does anything. I cannot find any relevant ERROR entry in log

bryphe commented 3 years ago

Similar issue to https://github.com/bartosz-antosik/vscode-spellright/issues/425 , just different versions.

The crash is here: https://github.com/bartosz-antosik/vscode-spellright/blob/1571dbd18ec7ff39b00211ae63051d0906003fe2/lib/bindings.js#L46

The place where things are failing is here: https://github.com/bartosz-antosik/vscode-spellright/blob/master/lib/bindings.js#L26 when it tries to load the native bindings.

In our case, the error when loading the bindings is: 

Failed: Error: The module '/Users/bryphe/.config/oni2/extensions/ban.spellright-3.0.56/lib/bin/spellchecker-darwin-9.1.0-x64.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 80. This version of Node.js requires
NODE_MODULE_VERSION 83. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

The extension is tightly coupled to a specific node version. We'd need to create a version of this extension that uses the same NODE_MODULE_VERSION as Onivim (we're on 14.5.4, with NODE_MODULE_VERSION of 83).

Samonitari commented 3 years ago

Well, thanks for the - quick as always - answer!

Maybe I'll fork the extension myself, and install it from file as: I am grateful for @bartosz-antosik's work, but neither does he reply in a reliable fashon, nor does Spell Right's commits come regularily lately. Still, it is a very good extension in my opinion...