search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.84k stars 282 forks source link

weird build-in terminal colors #3495

Closed jerabaul29 closed 3 years ago

jerabaul29 commented 3 years ago

I wonder if this has been already discussed, but the colors in the built in terminal look weird. I am running Ubuntu 20.04, "out of the box", nothing too special regarding my setup. See picture for comparison of the colors in Oni2 vs. my system terminal.

Any idea what causes that / how this can be fixed? A bit painful to my eyes and quite a lot less visible... Wonder if there should be a way to either 1) read terminal setup from some usual config files on the machine, or 2) be able to set a terminal theme?

Screenshot from 2021-05-04 11-04-44

bryphe commented 3 years ago

Ah, the terminal colors are actually determined by the theme:

2021-05-05 18 39 06

We could potentially provide a way to override the terminal colors, like: https://stackoverflow.com/questions/42307949/color-theme-for-vs-code-integrated-terminal

jerabaul29 commented 3 years ago

Aah, that explains, thanks :) . Maybe I should just use another theme ^^ :) .

bryphe commented 3 years ago

I also added a way to override terminal colors in #3506 - so you can manually specify them via a workbench.colorCustomizations setting.

This is a good starting set of colors to try, and then can be tweaked: https://github.com/Tyriar/vscode-snazzy/blob/c9484f46fa3f2ec44860b87fb51dfb9d1cbe2f85/snazzy.json#L5

bryphe commented 3 years ago

I'll close this out with #3506 👍