Uninstalling one version of an extension that has two versions installed removes both from list

onivim / oni2

Native, lightweight modal code editor

https://v2.onivim.io

MIT License

7.83k stars 282 forks source link

Open Minnozz opened 3 years ago

Minnozz commented 3 years ago

I installed rescript-vscode from the Open VSX Registry
I manually installed a newer version of rescript-vscode
The extensions list correctly showed both
I clicked "Uninstall" on the older version
The UI showed "Uninstalling" for both versions
Both versions disappeared from the list
Relaunch Onivim 2
The newer version of the extension is still installed, and the older version is removed (as intended)

bryphe commented 3 years ago

Thanks for logging the bug, @Minnozz !

It looks like our uninstall logic (https://github.com/onivim/oni2/blob/a904db33cb0c131135bb3f0c5c27037353d2c6c4/src/Service/Extensions/Management.re#L147) is only based on the extension ID, which isn't enough information to disambiguate cases like this - where extensions from different sources have the same ID. To fix this, we should send additional context (like the path of the extension, which we'd know when pressing 'uninstall') to disambiguate.