search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 282 forks source link

Oni2 doesn't load folders when folders are mounted from a nfs mount #3534

Closed edwinclement08 closed 3 years ago

edwinclement08 commented 3 years ago

/etc/fstab content eve.local:/mnt/user/Coding /home/edwin/coding nfs default 0 0 The folder contents image

The Oni Screen image

Note that the Oni terminal also shows the folder contents, but the side bar does not.

Working with code on a remote server is a critical piece of my workflow. I really want to stick with Oni, but unless this is fixed, I can't use it. I am up for a call/chat to fix this if you need to test things on my env.

bryphe commented 3 years ago

Thanks for logging the issue @edwinclement08 - possibly related to #3377

Trying to set up a repro on my end

edwinclement08 commented 3 years ago

If you need anything to reproduce, I am happy to help

edwinclement08 commented 3 years ago

Any progress on this end?

bryphe commented 3 years ago

Hi @edwinclement08 ,

Yes, actually - I have a repro environment now, and I've narrowed it down to this spot in the code:

https://github.com/onivim/oni2/blob/d5cd50280484b0ccc9dfef5908311be71262f31d/src/Components/FileExplorer/Component_FileExplorer.re#L35

Essentially, in this particular case (and likely #3377 as well), the filetype comes back as 'UNKNOWN' - requires an extra stat call to figure out if it is actually a file / folder.

So the fix will involve doing a stat on these returned on these files to determine the actual type (...and that extra context could help fix #2657 as well).

edwinclement08 commented 3 years ago

That was amazingly quick. Thanks.