onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.84k stars 282 forks source link

feat(windows): Customizable title bar style #3765

Closed bryphe closed 3 years ago

bryphe commented 3 years ago

Issue: There are several quirks on Windows with the 'undecorated' Windows style - issues like:

Fix: These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar.

This introduces a new setting - window.titleBarStyle that can be "native" or "custom". The "custom" titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to "native".

In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like "window.titleBarStyle" prior to opening the window.

Todo: