search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 281 forks source link

fix(A-scm/#2525): see git branches when using git checkout #3785

Closed Jakkestt closed 3 years ago

Jakkestt commented 3 years ago

See the git branches when using git checkout

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

bryphe commented 3 years ago

Hi @Jakkestt ,

Thanks for the PR and for investigating #2525 !

There's a couple of concerns that I have with the fix: 1) Modifying the git extension will make it difficult to merge updates from the upstream VSCode git extension 2) There are likely other extensions that create quickpick menus in a similar way, that are also broken.

Ideally, we could fix the root cause - that we're not handling the API surface the Git extension is using. I'm testing this out in #3791 , which implements some of the missing APIs. It was definitely helpful to have this PR to see the broken APIs!

Jakkestt commented 3 years ago

Well shit. I followed all the guides like a good boy and in the end I don't get shit.