onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.83k stars 281 forks source link

Add hover scroll by keyboard #3804

Open joseemds opened 3 years ago

joseemds commented 3 years ago

I've been trying to add the command to scroll the hover popup, but i am stuck at how should i update HoverView, first i thought about exposing a HoverView.update function, but then how would i know the current value? Since the scroll is basically increase and decrease that value, in my mind the process is: Check if there is some active session, if so get the scrollTop value and update it depending on the command. My question is where should i expose the scrollTop value?

Please tell if there is something wrong in my logic