search

onivim / oni2

Native, lightweight modal code editor
https://v2.onivim.io
MIT License
7.78k stars 274 forks source link

Leader key customization #382

Open WEBhicham opened 5 years ago

WEBhicham commented 5 years ago

proposal

In a lot of vim like editors or vim distributions they have amazing space-key customization. You have spacevim and spacemacs where the Leader key (in this case space) is you primary form of executing commands. It would be lovely if oni2 at some point could have this as well.

This would include of being able to map <leader>-s-s to save all files for example. of course there has to be a setting to set your leader key. for people who rather use some other key as their leader key.

reyzavk commented 5 years ago

It will be wonderful if we can emulate spacemacs/spacevim's keybind and functionality without additional configuration. It's so powerful, it's one of the main reasons I still use spacemacs/spacevim instead of vscode/atom.

yunti commented 4 years ago

Is there an issue for more general vim key rebindings like escape to jk etc....? (I couldn't find one)

CrossR commented 4 years ago

Is there an issue for more general vim key rebindings like escape to jk etc....? (I couldn't find one)

There isn't but that specific example is a known case, which we are working to support (https://github.com/onivim/libvim/pull/101). Ideally, you'd be able to use basically all the same bindings as normal vim, and have them enhanced to be GUI-aware (ie Ctrl-w-h/j/k/l to move between buffers, but also the explorer / Oni2 windows etc).

yunti commented 4 years ago

@CrossR Thanks that's good to know ; for : is the other key one for me that's just too ingrained, the others I can workaround. Let me know if it would be helpful to post a seperate issue for customising vim keybindings, or if this one is sufficient?

yunti commented 4 years ago

jk for escape now added in, https://github.com/onivim/oni2/commit/93a2283bf36f6027f1f59326ca3c644f7322e89a

jamischarles commented 4 years ago

Is it possible to use space as a modifier currently? I wasn't able to find it listed anywhere.

AkechiShiro commented 4 years ago

@jamischarles I can confirm that space is usable (I didn't find it listed anywhere too but just tried something on a whim) here is the config I used in my keybinding file and it works as expected : 

{ "key": "<space>w", "command": "workbench.action.files.save", "when": "normalMode" }