search

onkelDead / tascam-gtk

GTK+ based application to control Tascam US-16x08 DSP mixer
MIT License
56 stars 12 forks source link

Moving Past libxml++-2.6 #24

Closed dhtseany closed 1 year ago

dhtseany commented 1 year ago

Hello,

This app is of vital importance to me as it's the only method of altering my Tascam 16x08's settings on my Linux systems, in my case Arch Linux.

libxml++-2.6 was released on May 5th 2004; it's hyper old at this point and requiring it for building and usage is preventing me from adjusting my Tascam on a fresh system.

What, if any, are the plans for this app to get an overhaul to a more current version of libxml++ so it's lifespan can be extended?

I'll contribute at least $100 if you're willing to put in the dev effort to start using the newer versions of libxml++ that are natively included in most modern distros, currently 3.2.4. Thanks!

be1 commented 1 year ago

Hello @dhtseany Not sure, but I think libxml++2.6 to libxml++5.0 are API compatible to libxml++2.6. So this might be just a matter, for Arch, of modifying the configure.ac file to require the version that is on Arch. On Ubuntu kinetic, this seems to be transparent. Maybe I'm wrong, but you can give a try on changing the line 27 of configure.ac and then run autoreconf to regenerate a fresh configure script.

dhtseany commented 1 year ago

@be1 Thanks for the tip! I've been playing with your suggestion for the last hour or so and while I'm able to clear the hurdle with ./configure I'm still not able to build because the version (2.6) seems to have been hard-coded into the app and in turn make isn't able to complete the make process. Any other advice for patching a fix to get it to not reference 2.6 would be appreciated.

be1 commented 1 year ago

@dhtseany I have some spare time and I will install an Arch in a VM, then try to make it work...

EDIT: I had troubles with Arch, but I eventually could make tascam-gtk compile with libxml++3.x on my personal repo : @dhtseany Please do git clone https://github.com/be1/tascam-gtk.git somewhere else, then run autoreconf, then ./configure then make, then please test if the generated binary ./tascamgtk works (I could not test it, because my Arch doe not have a graphical environment). Tell me if something goes wrong.

dhtseany commented 1 year ago

@be1 Your efforts are most appreciated, I can confirm that your fork works and I was able to build and run tascam-gtk with libxml++ 3.2.4-1.

As I maintain other packages on the AUR I planned to submit our finished product for others to benefit with an easier installation experience, at least for Arch users and since I use this quite often I don't mind keeping it patched.

Can you please clarify what changes were made that allowed 3.2.4 to be used? I imagine you updated the source to reflect the updated version numbers, is this something we can do a pull request that @onkelDead might accept? Ideally I'd like to simply use the primary repository instead of your fork. Thanks again!

be1 commented 1 year ago

@dhtseany this was not very hard to patch. See https://github.com/be1/tascam-gtk/commit/5e1f1647563eb72f82566bb22c6e60b6bbecd051 Unlike Arch, several distributions seem to ship a modified version of libxml++2.6 instead of mutiple versioned libxml++. So I would say it is not a good idea to submit my patch to @onkelDead repository as is, because it will fail to build on those distributions. The best would be to make configure script to allow choosing the libxml++ version to use, but I'm not used to autotools (autoconf / automake) and will have difficulties to achieve that.

EDIT: I am willing to achieve multiple libxml++ version detection. Would be happy for any compensation, as mentioned before.

onkelDead commented 1 year ago

@be1 I really appreciate your work, many thanx.

I've validated #25 and will apply it to the master.

Greets, Detlef

be1 commented 1 year ago

@be1 I really appreciate your work, many thanx.

I've validated #25 and will apply it to the master.

Greets, Detlef

Thanks @onkelDead ! Your application is a must-have for us having a Tascam US-16x08, yet. Thanks to you!

be1 commented 1 year ago

@dhtseany I think you can close the issue if you are satisfied, as the patches have now been merged upstream. Can you confirm it works for you? I don't know it it is legal in my country to have financial compensation as you mentioned. But I think a symbolic tip is okay.

dhtseany commented 1 year ago

Thanks to @be1 for helping craft a good workaround solution for those of us with libxml++-3.0 or newer, I can confirm that your merged work does indeed build and run thus fixing our issues on Arch Linux.