search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
513 stars 111 forks source link

Velocity mode #390

Closed Rodrix33333 closed 1 year ago

Rodrix33333 commented 1 year ago

The velocity mode lights up correctly the key led; however it fails to correctly light up the side leds. They fade out very quickly and only one led remains lit.

I see the code is affected by control pedal. This might be the issue. How is the pedal supposed to affect this behavior?

What is the pedal "dead zone" in the vars?

I have a continuous pedal controller which outputs different values (half pedalling is supported). If I understand I might be able to help fix a bug.

Thanks for this awesome project. It's incredible 💫🍦

onlaj commented 1 year ago

I think I overcomplicated that part. It should be easier to redesign Velocity mode to ignore pedal signal and then add "the pedal keeps the LEDs lit" applicable to all light modes.

Rodrix33333 commented 1 year ago

I think that's a great idea! I like the new branch proposal.