search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
498 stars 107 forks source link

Scale mode bug #393

Open Rodrix33333 opened 1 year ago

Rodrix33333 commented 1 year ago

Scale mode produces an index out of range, when playing too many notes. This is a bug.

onlaj commented 1 year ago

Can you tell me how to reproduce that error? I thought it occurs when you press the highest or lowest key, but it works just fine for me.

Rodrix33333 commented 1 year ago

Playing many keys, fast, simultaneously, triggers the error. I was just playing classical music, nothing too weird.

On Wed, Nov 9, 2022, 07:55 onlaj @.***> wrote:

Can you tell me how to reproduce that error? I thought it occurs when you press the highest or lowest key, but it works just fine for me.

— Reply to this email directly, view it on GitHub https://github.com/onlaj/Piano-LED-Visualizer/issues/393#issuecomment-1308570755, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3P3MMDZPSB5KO3WJRHKYZ3WHN7KFANCNFSM6AAAAAARPDK6A4 . You are receiving this because you authored the thread.Message ID: @.***>

onlaj commented 1 year ago

I was just pressing many notes randomly, but it doesn't crash for me. Can you show me the full error message?

Rodrix33333 commented 1 year ago

Change the scale to E minor (g major) I think that was it.

On Thu, Nov 10, 2022, 05:19 onlaj @.***> wrote:

I was just pressing many notes randomly, but it doesn't crash for me. Can you show me the full error message?

— Reply to this email directly, view it on GitHub https://github.com/onlaj/Piano-LED-Visualizer/issues/393#issuecomment-1309927451, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3P3MME5G6ZLRJMN544WJLTWHSVYLANCNFSM6AAAAAARPDK6A4 . You are receiving this because you authored the thread.Message ID: @.***>

onlaj commented 1 year ago

I checked all scales, still can't reproduce that error. Can you show me error message? At which line the error occurs?