search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
498 stars 107 forks source link

Rainbow mode expansion (feature) #394

Open Rodrix33333 opened 1 year ago

Rodrix33333 commented 1 year ago

Rainbow mode is amazing.

To make it even better I suggest:

1) be able to change the gradients (so it's just a hue animation of reds, for example. Or a rainbow of fire colors).

Maybe what we actually need to do is to add a new functionality to gradients: time and scale for the animation.

2) to make the speed time factor, change depending on how many notes are pressed.

Rodrix33333 commented 1 year ago

Let me rewrite this:

1) add time and scale to gradient mode. 2) add the possiblity of multi point gradients.

That's all we need. No need to touch the rainbow mode.

Nbobito commented 1 year ago

What if there was a way to create custom animations and gradients? They could be created using some tool in the web interface, then saved as an animation file.

Rodrix33333 commented 1 year ago

No need to have animation files, I believe. Multi point gradients would be enough. As a setting.

What type of animations do you have in mind. I am interested

onlaj commented 1 year ago

add the possiblity of multi point gradients.

That I can do. I think SeeMusic has this feature too, so it will work great together.

onlaj commented 1 year ago

@Rodrix33333 @Nbobito Instead of adding new color mode I added gradient to already existing Multicolor. You add gradient by NOT assigning range. Instead of not lighting keys it takes the closest colors from left and right and mix them together creating a gradient.

ZYIdtPI

PXL_20221102_112150524

Branch, if you want to test it before merging: https://github.com/onlaj/Piano-LED-Visualizer/commit/43aa882c04c35140c812d8928c5c9eb24b19a83c

Rodrix33333 commented 1 year ago

Looking great!!! Do you think you can add the time animation feature (as in Rainbow)? Could be 0 for no animation. Looking forward to testing it!

Rodrix33333 commented 1 year ago

It's looking great! Could you add the time feature for the multicolor?

Rodrix33333 commented 1 year ago

Time and scale

onlaj commented 1 year ago

Time, maybe. But why scale?

onlaj commented 1 year ago

Nvm, I thought about it for a while and I can see some use cases. Added to to-do list.

Rodrix33333 commented 1 year ago

Awesome!

On Tue, Nov 8, 2022, 14:01 onlaj @.***> wrote:

Nvm, I thought about it for a while and I can see some usecases. Added to to-do list.

— Reply to this email directly, view it on GitHub https://github.com/onlaj/Piano-LED-Visualizer/issues/394#issuecomment-1307534151, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3P3MMHTL6NTDYBOCRHD3EDWHKBN7ANCNFSM6AAAAAARPSMYDQ . You are receiving this because you were mentioned.Message ID: @.***>

rodrix385 commented 1 year ago

I am back!!! I am looking forward to expanding your source code. Are you still active? :)

onlaj commented 1 year ago

Yes, but my RPi is fried and I still didn't buy new one, so I can't make any tests. I will try to find some replacement.