search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
494 stars 107 forks source link

Support for 160 leds/m strip #459

Closed David-Guow closed 11 months ago

David-Guow commented 12 months ago

160 leds/m is more commonly available now in 2 m length. Would you please point me to a direction on which part of code needs to be modified to make 160 leds/m strip work? Thanks

onlaj commented 12 months ago

Hello, I'm working on a feature that will add support for any kind of leds density, stay tuned. Or if you want to change it right now for yourself, take a look at this commit

David-Guow commented 12 months ago

Thanks a lot for the fast reply, I will stay tuned for sure. Tried to follow the steps from the commit and a few different density for my case. However the Led strip will not light up the right most 30 or so leds. I'm guessing it has a limit for leds set by the 144 /m strips? I'm not too good with coding, it's really appreciated to know you are working on this feature!

onlaj commented 12 months ago

You have to change number of leds,it can be done through web interface, lcd screen's menu or by editing config/settings.xml

Screenshot 2023-07-14 at 15 45 59
David-Guow commented 12 months ago

I changed the led counts to 196 for my case. The leds distances are "shrinked" and would not light up the parts corresponding the the right most 5 or 6 white keys. Adjust the density didn't work for my case.

onlaj commented 12 months ago

Yep, without editing the code it won't align properly with that led strip. Basically you need to change leds_per_meter = 144 to leds_per_meter = 160

Then you can use LED Note Offset for final adjustments.

onlaj commented 11 months ago

@David-Guow I updated the code. Now, instead of "low density" you can specify how many leds there are per meter on your led strip.

David-Guow commented 11 months ago

Thank you so much! I will give it a try!

David Guo

From: onlaj @.> Sent: Tuesday, July 18, 2023 10:53:16 AM To: onlaj/Piano-LED-Visualizer @.> Cc: David-Guow @.>; Mention @.> Subject: Re: [onlaj/Piano-LED-Visualizer] Support for 160 leds/m strip (Issue #459)

@David-Guowhttps://github.com/David-Guow I updated the code. Now, instead of "low density" you can specify how many leds there are per meter on your led strip.

— Reply to this email directly, view it on GitHubhttps://github.com/onlaj/Piano-LED-Visualizer/issues/459#issuecomment-1640382538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BA62FQMXVFOMFKW53AIJYZ3XQ2PNZANCNFSM6AAAAAA2KKZH6M. You are receiving this because you were mentioned.Message ID: @.***>

David-Guow commented 11 months ago

It works great! Using a 160/M led strip. Thank you for everything!

David Guo

From: David Guo @.> Sent: Tuesday, July 18, 2023 10:53:56 AM To: onlaj/Piano-LED-Visualizer @.>; onlaj/Piano-LED-Visualizer @.> Cc: Mention @.> Subject: Re: [onlaj/Piano-LED-Visualizer] Support for 160 leds/m strip (Issue #459)

Thank you so much! I will give it a try!

David Guo

From: onlaj @.> Sent: Tuesday, July 18, 2023 10:53:16 AM To: onlaj/Piano-LED-Visualizer @.> Cc: David-Guow @.>; Mention @.> Subject: Re: [onlaj/Piano-LED-Visualizer] Support for 160 leds/m strip (Issue #459)

@David-Guowhttps://github.com/David-Guow I updated the code. Now, instead of "low density" you can specify how many leds there are per meter on your led strip.

— Reply to this email directly, view it on GitHubhttps://github.com/onlaj/Piano-LED-Visualizer/issues/459#issuecomment-1640382538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BA62FQMXVFOMFKW53AIJYZ3XQ2PNZANCNFSM6AAAAAA2KKZH6M. You are receiving this because you were mentioned.Message ID: @.***>