search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
531 stars 112 forks source link

hotspot fixups #471

Closed stephen322 closed 1 year ago

stephen322 commented 1 year ago

Change to check package installed only once. Errors in a loop on my system otherwise. (I do not have hostapd installed).

onlaj commented 1 year ago

Does it crash or just throws an error? I will try to test it on version 1.4 before merging.

stephen322 commented 1 year ago

Does not crash. But fills my console with errors while I debug my own stuff. Seems to be expensively checking for package on every event loop. It's a quick fix on my machine, but I did not thoroughly test since I don't use hostapd.

onlaj commented 1 year ago

You're right, this is expensive condition if hostapd is not installed. The good thing is that I don't need to include it before version 1.5, because hostapd will be installed there by default.