search

onlaj / Piano-LED-Visualizer

Piano LED Visualizer: Connect an LED strip to your Raspberry Pi and create an immersive visual experience for your piano playing
MIT License
531 stars 112 forks source link

Rainbow Color: Colormap support #488

Closed stephen322 closed 10 months ago

stephen322 commented 11 months ago

Fixed web preview to take into account led position due to led_count, leds_per_meter, reverse strip. I would think we should change the Rainbow Color itself instead (to use note number, not led position), but I'm not sure if backwards compatibility is important here.

onlaj commented 11 months ago

The preview does not match LED strip, is it the same in your setup? On the left it's red, green in the middle and blue on the right (blue starting at about 4/5 of length), while the preview looks like on screenshot.

Screenshot 2023-11-09 at 15 16 09

Also, is the appearance of this preview intentional? I'm referring to the large rectangle above the piano svg. I know it's just a matter of aesthetics, but I prefer the previous look more, where there was thin strip simulating LED strip. Can I change it later?

stephen322 commented 11 months ago

The range of red to green should have been fixed by the latest push that was added later: Rainbow Color: Fix web preview. If it still looks like that there's probably something wrong.

The piano svg looks wrong compared to my browser. I'll have to investigate that one.