search

online-bridge-hackathon / DDS

An api that returns DDS results for a given deal or partial deal
https://bit.ly/bridge-hackathon
Apache License 2.0
4 stars 6 forks source link

Updated imports to use standard Python packaging. #59

Closed tameware closed 4 years ago

tameware commented 4 years ago

I've confirmed that this works when deployed to GCP. It's running in our dev environment now.

tameware commented 4 years ago

It would be nice to add link to the answer in commit message.

Which answer, the one on StackOverflow? Alex didn't want to post there, so I'll end up answering my own question.

I've updated the commit message per what I think you're suggesting.

suokko commented 4 years ago

It would be nice to add link to the answer in commit message.

Which answer, the one on StackOverflow? Alex didn't want to post there, so I'll end up answering my own question.

I've updated the commit message per what I think you're suggesting.

Has the fellow of python Alex joined Hackathon? That would make me more comfortable to use python if there is someone with a lot python knowledge.

Sorry. I suspect it was an stackoverflow answer. In that case it would be nice to has first line of commit message a short in the point header about change. Followed by an empty line. Then a more detailed explanation how this changes makes sure module internal imports and external imports. Also credit for the idea should go to the detailed part of commit message.

tameware commented 4 years ago

Alex Martelli has signed up fr the Hackathon. Whether he has time to join actively is another matter! He's the author of a few of O'Reilly's Python Books and also a few Bridge World articles.