search

online-bridge-hackathon / DDS

An api that returns DDS results for a given deal or partial deal
https://bit.ly/bridge-hackathon
Apache License 2.0
4 stars 6 forks source link

Added DDS service to prod #64

Closed kiat-huang closed 4 years ago

kiat-huang commented 4 years ago

Made the Helm chart files a little more modular and simple to edit. Updated the Makefile and charts for Prod

tameware commented 4 years ago

We should be able to deploy to either environment with files from HEAD. Please either add a flag for the environment or commit two separate Makefiles. The latter violates the DRY principle, but it would be fine as a stopgap until we refactor. And maybe we are going to abandon the old environment anyway.

Now that I think about it, best is probably two separate deploy targets, with the difference being how they set RELEASE_NAME.

kiat-huang commented 4 years ago

Hold off further work on this until the two other PRs have been merged, then I'll refactor as needed.

kiat-huang commented 4 years ago

Closing, not sure it is needed now.