search

online-go / goban

A JavaScript library for exploring and playing the game of Go
Apache License 2.0
46 stars 40 forks source link

GoEngine: remove ogs_import from config #140

Closed benjaminpjones closed 10 months ago

benjaminpjones commented 10 months ago

There is a comment here that the field is deprecated and we no longer use it, but how to be sure?

https://github.com/online-go/goban/blob/main/src/GoEngine.ts#L202-L203

Maybe some error logs?

benjaminpjones commented 10 months ago

@hexahedron posted about some older games that seem to have this.. seems like stuff will break if it's removed..

https://forums.online-go.com/t/can-we-get-an-sgf-database-dump/38837/79?u=benjito

Here is the game that has that field: https://online-go.com/game/262294. Note: the REST API does not include it, but the socket API does.