search

online-go / goban

A JavaScript library for exploring and playing the game of Go
Apache License 2.0
47 stars 39 forks source link

Fix ScoreEstimator bug for Japanese scoring #142

Closed benjaminpjones closed 10 months ago

benjaminpjones commented 10 months ago

This bug was introduced in d6194f4c46fdf90b8a12de091b038939230b8ca1 and caused captures to be multiplied by a factor of height.

https://forums.online-go.com/t/in-game-score-estimator-bugged/50046

Testing: I added a unit test based on stone_defender's demo board. 8x8 instead of 20x20.

anoek commented 10 months ago

Thanks for the fix!