Open dexonsmith opened 9 months ago
My first impression is that this is not a small project, since (a) the parsers/etc. lack the concept of an edit without a move node and (b) any changes here need to be super-well tested (a mistake could break real games).
I do think this is tractable. I just think it's critical to get the testing right.
From the forums: https://forums.online-go.com/t/condense-edited-position-in-game-tree/50637
The GoEngine can't handle multiple edits in the same move node, so the first step is here in https://github.com/online-go/goban. This should be easy to add tests for, by parsing and/or dumping SGFs.
From the forum discussion:
;
indicates a new game tree nodeB
andW
are moves.;B
and;W
in practice.AB
andAW
indicate edits.;AB[aa]
is a new node with a black edit;AB[aa][ab]
is a new node with two black edits;AB[ff][fg]AW[ef][eg]AB[fh]
is a new node with five editsEDIT: the follow-up to expose this in the analysis interface is https://github.com/online-go/online-go.com/issues/2559.