search

online-go / goratings

This repository contains the (future) official rating and ranking system for online-go.com, as well as analysis code and data to develop that system and compare it to other reference systems.
MIT License
19 stars 6 forks source link

Centralize skipping logic in analysis.util.SkipLogic #49

Closed dexonsmith closed 11 months ago

dexonsmith commented 11 months ago

The skipping logic is duplicated across analysis scripts. It also seems a bit stale outside of ./analysis/analyze_glicko2_one_game_at_a_time.py. Centralize it into a new helper utility.

This is mainly so that #46 can extend it without duplicating more code.

anoek commented 11 months ago

Yeah good cleanup (and fixes, some bad timeout bugs in there for some of the less used scripts), thanks! I think it's just those two things and we're good to go