online-go / goratings

This repository contains the (future) official rating and ranking system for online-go.com, as well as analysis code and data to develop that system and compare it to other reference systems.
MIT License
19 stars 6 forks source link

When tallying, cap the expected win rate at 1:1M #57

Closed dexonsmith closed 10 months ago

dexonsmith commented 10 months ago

Cap the expected win rate to 1 in a million when tallying game analytics. This prevents math domain errors here regardless of what the Glicko-2 math functions return.

Effectively replaces #54 (although that could still be committed).

Relates to #45.

dexonsmith commented 10 months ago

This prevents math domain errors here

To be clear, "here" is the "computation of the prediction_cost metric".

anoek commented 10 months ago

Interesting that that prediction returns values in excess of those bounds. Thanks for the patch :)