online-go / gtp2ogs

GTP Wrapper to allow bots to interface with the Online-Go.com Server
MIT License
88 stars 29 forks source link

Allow custom decline all message #403

Closed Dorus closed 4 months ago

Dorus commented 1 year ago

When decline_new_challenges is set to true, i'de like to inform the users why.

I tried to code this myself, but failed to do so:

https://github.com/Dorus/gtp2ogs/tree/decline-message

Despite the logs showing i send "This bot is not accepting new challenges at this time. Off during heatwave. Will return."

Jun 10 12:19:13   util.ts:35           POST /api/v1/me/challenges/20749891 {"delete":true,"message":"This bot is not accepting new challenges at this time. Off during heatwave. Will return.","rejection_details":{"rejection_code":"not_accepting_new_challenges","details":{},"message":"This bot is not accepting new challenges at this time. Off during heatwave. Will return."}}

The ogs interface only shows:

afbeelding

I even noticed the default message send by gtp2ogs is "This bot is not accepting new challenges at this time.", but the interface always shows "This bot is not accepting new challenges at this time" without the dot.

Dorus commented 1 year ago

Some future thoughts:

I know ogs is going to change the interface for sending bot challenges, and i guess this is going to tie into that. For now the rejection_code seems to take precedence over the reject code. Is there any good reason for that? (I'm thinking translation, but for now the reject reason is not translated, and also, i would prefer to keep that responsibility on the gtp2ogs side)

Also it's not possible to send multiple reject reasons now. That's another thing i've always wanted to see.

(Again with the changes to the bot challenge interface, this might or might not be relevant anymore)

Even with the new interface, what will happen when an edge-case is missed and the bot still reject (or config changes while the page was open?) I guess the bot reject message will continue to be relevant.

anoek commented 1 year ago

I'll keep this all in mind as we work through updating the interface updates.

github-actions[bot] commented 4 months ago

This issue has been marked stale and will be closed soon without further activity. To keep the issue open, please respond to the comment to keep the discussion going.

github-actions[bot] commented 4 months ago

This issue has been automatically closed due to inactivity. Please feel free to re-open it if the issue persists.