online-go / online-go.com

Source code for the Online-Go.com web interface
https://online-go.com/
GNU Affero General Public License v3.0
1.25k stars 345 forks source link

Save remaining time for each player in SGFs and display it in game analysis and review #1204

Open marant opened 4 years ago

marant commented 4 years ago

Is your feature request related to a problem? Please describe. I'd like to have remaining time for both players stored in the downloadable SGFs. I would also like to be able to view this information in game analysis and game reviews. In game review and analysis, the time could be displayed where the remaining time is displayed during the game.

Describe the solution you'd like It is possible to store this information in custom SGF properties. KGS has this feature and KGS stores the information in BL and WL properties. The used format is apparently seconds remaining as a floating point value. For example:

I think it would be a good idea to use the same properties as KGS. I use KGS's cgoban to analyze and annotate SGF files and I'd like to be able to view this information in cgoban for games played on OGS as well.

Additional context I think it is useful for players to be able to analyze how they spend their time after a game.

marant commented 4 years ago

BL and WL properties are mentioned in the SGF specification as the properties to store remaining time: https://www.red-bean.com/sgf/proplist_ff.html

shinuito commented 3 years ago

This is being requested quite frequently

https://forums.online-go.com/t/is-there-a-way-to-see-how-long-you-took-for-a-move-when-reviewing-a-game/32324?u=shinuito

https://forums.online-go.com/t/store-display-timestamps-for-each-move/38305?u=shinuito

https://forums.online-go.com/t/sgfs-playback-by-move-time/38157?u=shinuito

github-actions[bot] commented 1 year ago

This issue has been marked stale and will be closed soon without further activity. To keep the issue open, please respond to the comment to keep the discussion going.