search

online-go / online-go.com

Source code for the Online-Go.com web interface
https://online-go.com/
GNU Affero General Public License v3.0
1.23k stars 345 forks source link

Score estimator hides captured stones #1666

Closed pdg137 closed 1 year ago

pdg137 commented 2 years ago

Describe the bug When in the score estimator, the count of captured stones is invisible. I don't see any reason for this, and it will be especially confusing with the changes to goban.js accounting for Japanese rules. I'm pretty sure it's intentional, maybe someone thought that estimating the score would actually remove some stones on the board, possibly making these counts misleading? But it doesn't do that.

To Reproduce Steps to reproduce the behavior:

  1. Go to a game
  2. Click on "Estimate Score"
  3. See the captured stone counts disappear

Expected behavior Should not hide captures.

Screenshots image

anoek commented 2 years ago

When dealing with area scoring, captured stones is irrelevant, which is probably why I hid it? But yeah with your new territory estimation stuff, that should probably be in there

pdg137 commented 2 years ago

Right, but captured stones are shown during the rest of Chinese games - why just hide them in the SE?

anoek commented 2 years ago

:shrug:

anoek commented 2 years ago

I'm fine with it being enabled for all games, I don't think there was a particular reason not to, other than no one has complained about it loud enough to me, at the right time when I could pay attention :)