online-go / online-go.com

Source code for the Online-Go.com web interface
https://online-go.com/
GNU Affero General Public License v3.0
1.19k stars 332 forks source link

Shorter clock strings: "6 Days 3 Hours" -> "6d 3h" #2652

Closed benjaminpjones closed 1 month ago

benjaminpjones commented 2 months ago

This is an attempt to prevent wraparound in narrow contexts, which can cause layout issues in the player cards on the Game page. See discussion/poll at OGF: Should time control show days without hours?

To summarize, the "6d 3h" format the overwhelming preference (93%) in the multiple choice poll. One user cited precision as a reason for choosing this over an option like "6 Days" that keeps long-form units, but drops hours. Another user pointed out that the Sente Android app uses this format.

Proposed Changes

I've broken this into four commits:

Screenshots

Notice, we get one line of vertical space back on both the player cards and the active games list. This is critical for phone screens!

Screenshot 2024-04-02 at 10 03 28 PM Screenshot 2024-04-02 at 10 05 21 PM Screenshot 2024-04-02 at 10 06 24 PM Screenshot 2024-04-02 at 10 06 08 PM
github-actions[bot] commented 2 months ago

Uffizzi Preview deployment-49367 was deleted.

anoek commented 1 month ago

Awesome, thanks for checking in with the community. 93% approval has got to be a record :)