online-go / online-go.com

Source code for the Online-Go.com web interface
https://online-go.com/
GNU Affero General Public License v3.0
1.2k stars 336 forks source link

GoTV twitch chat cookies prompt #2729

Open shinuito opened 6 days ago

shinuito commented 6 days ago

One possible issue that I’m not sure if you can actually fix, with the iframe for the chat, I can’t see the button to accept/reject the cookies popup.

image

Maybe if the iframe/chat window can be scrollable it’ll help with that?

Originally posted by @shinuito in https://github.com/online-go/online-go.com/issues/2721#issuecomment-2183915000

^^ I think this one still seems to be an issue. For me it’s on Safari on mobile. I saw another user mention it, but not sure what browser they’re using or if it’s a mobile issue for them actually.

shinuito commented 6 days ago

“I see the accept button, but it does nothing when I click on it. On the Edge browser it works. Im using Firefox here.”

From a particular user in one of the chats, if that’s helpful :)

shinuito commented 6 days ago

If I drag up for instance it just brings the whole outer page up, rather than just the inner chat iframe

image
RubyMineshaft commented 5 days ago

I assumed that this was caused by the chat pane extending beyond the viewport in the initial version of the due to the way the viewport height was being calculated on mobile browsers and that it would have been fixed when that problem was fixed. Clearly that's not the case.

I think these cookie notices must be region specific because i'm not able to get the cookie notice to come up for testing after clearing browsing data and even downloading and using a new browser. Anyone have any ideas?

shinuito commented 5 days ago

So when I accept it, I just go into a new private browsing tab or window and I get it again. It could be region specific, maybe Europe with GDPR is getting much more of these than elsewhere, I mean the number of notices about cookies on every website drives me crazy generally :)

Actually the way I can click accept is to use the “Find on page” and search for the word accept. Then it kind of scrolls to accept button and I can click it. Possibly not super obvious, but it technically works.

RubyMineshaft commented 5 days ago

It does seem to be specific to Europe. With my vpn on, I'm able to get the notice and even on my laptop, I can't see all of the buttons and it will not scroll.

Screenshot 2024-06-25 at 12 16 51 PM
RubyMineshaft commented 5 days ago

I went to report the issue to Twitch, but it looks as though they are already tracking it.

https://github.com/twitchdev/issues/issues/881