search

online-go / online-go.com

Source code for the Online-Go.com web interface
https://online-go.com/
GNU Affero General Public License v3.0
1.2k stars 336 forks source link

Duplicate trophies #679

Open flovo opened 5 years ago

flovo commented 5 years ago

Summary

Profile contains duplicate trophies badges for the same tournament.

$curl -s https://online-go.com/api/v1/players/449941/full | jq .trophies[].tournament_id
39559
39400
39400
28660
38587
39348
28819

in this case there are 2 copies (both 3rd place) of the trophy for tournament 39400.

If this happens for a tournament all 3 winners are affected.

Additional Information:

I've run a script to find some more cases. It seems, that all tournaments of type single elimination are affected. The other types are sometimes affected by this bug, but not that often.

Here is a list of some (at most 4) tournaments with this bug.

type affected tournament ids
elimination 39701, 39687, 39658, 39638
double_elimination 39679, 39598, 39537, 39112
swiss 39511, 38028, 37018, 36843
mcmahon 38767, 38662, 38514, 37976
roundrobin 38926, 37352
s_mcmahon 29748, 2495, 2469

This bug was postet in the Forum, too: Duplicate trophies, Received two medals for a single tournament, Tournament assigned two games at once to each player

Edit: I'm pretty sure this happens if two players have a equal position after taking all tiebreakers into account.

anoek commented 2 years ago

This issue has been marked stale and will be closed soon without further activity. To keep the issue open, please respond to the comment to keep the discussion going.

anoek commented 2 years ago

Bumping, this is not stale and is rather annoying

github-actions[bot] commented 6 months ago

This issue has been marked stale and will be closed soon without further activity. To keep the issue open, please respond to the comment to keep the discussion going.

anoek commented 6 months ago

hush stale bot, I'll get to it before 2030

BHydden commented 6 months ago

!Remindmebot 1-1-2030 😉

nikanar commented 3 months ago

Mind a little bump ?

Also seems a fair space to mention one missing asset - in my profile (666139) I have (for the tournament - https://online-go.com/tournament/72351) But https://cdn.online-go.com/5.1/img/trophies/silver_tourn_7.png does not seem to exist. (nor gold, and so logically the tournament winner - https://online-go.com/player/119707/gazzawhite - has the same issue)

Let me know if you'd rather have a separate bug report