online-ml / river

🌊 Online machine learning in Python
https://riverml.xyz
BSD 3-Clause "New" or "Revised" License
5.1k stars 551 forks source link

Nearest neighbor search in DBSTREAM #1261

Open slvnwhrl opened 1 year ago

slvnwhrl commented 1 year ago

Hi there,

I was wondering whether there is a reason that DBSTREAM does not use k-d tree for nearest neighbor search (as also suggested in the original paper)?

Thank you!

MaxHalford commented 1 year ago

For you @hoanganhngo610!

hoanganhngo610 commented 1 year ago

Thank you so much @slvnwhrl for the question! I will look again at the implementation and the paper once again, but it may take a little bit of time. Once I'm come up with either an explanation or a modification in the implementation, I will let you know immediately!

slvnwhrl commented 1 year ago

Thank you so much @slvnwhrl for the question! I will look again at the implementation and the paper once again, but it may take a little bit of time. Once I'm come up with either an explanation or a modification in the implementation, I will let you know immediately!

Sounds like a plan, thanks!