no MSG_DONTWAIT in PHP 5.* for windows

onlinecity / php-smpp

PHP 5 based SMPP client library

232 stars 160 forks source link

no MSG_DONTWAIT in PHP 5.* for windows #13

Closed anton0xf closed 9 years ago

anton0xf commented 11 years ago

Because of bug https://bugs.php.net/bug.php?id=48326 line sockettransport.class.php:327 fails on windows.

anton0xf commented 11 years ago

I locally replace it by MSG_WAITALL. But I don't understand is it good approach.

cypres commented 11 years ago

I wouldn't attempt to run SocketTransport on windows. It was made for berkeley sockets, which windows don't support.

You might have better luck with the windows compatible branch; https://github.com/onlinecity/php-smpp/tree/windows-compatible - although that has not been maintained for some time.

anton0xf commented 11 years ago

But it works after this simple change

cypres commented 9 years ago

Replacing MSG_DONTWAIT with MSG_WAITALL is a behavior change, and could introduce other issues with connection maintenance. Besides I don't think it's going to work on windows with the sockets extension.