search

onlinecity / php-smpp

PHP 5 based SMPP client library
232 stars 160 forks source link

Re-organize code, add bindTransceiver, and set $sms_null_terminate_octetstrings = false as default #98

Closed alexandr-mironov closed 3 years ago

alexandr-mironov commented 3 years ago

Hello, Your project is awesome, but current code organizing is deprecated (many classes in one file, very long lines and ect.), im re-organize your code, add bindTransceiver method, and set $sms_null_terminate_octetstrings = false as default value because (as you already know) since SMPP v3.4 null termination is not neccessaury and many of modern application (for example: cloudhopper) can't recognize packet with null termination

im change package name in composer.json to use my fork, pls change it back to php-smpp/php-smpp if you accept my "lazy" pull request. Sorry if my English bad, its not native. Best regards!

jwldk commented 3 years ago

Hi. First of all thanks for taking the time to cleanup this old code of ours. However it is not maintained anymore, so I suggest you make a fork instead. Then we will be happy to link to it in the README to help others in the right direction.

alexandr-mironov commented 3 years ago

Hello, i'm update my fork of your repository, update readme, do some small fixes and code readability, and i think its ready to put link of my fork to your original repository (if it acceptable)

https://github.com/alexandr-mironov/php-smpp

Thanks and best regards!